Skip to content

Give user control of option skip_sanity_check#7190

Merged
jpakkane merged 1 commit intomesonbuild:masterfrom
Neumann-A:user_controls_skip_sanity_check
Jul 4, 2020
Merged

Give user control of option skip_sanity_check#7190
jpakkane merged 1 commit intomesonbuild:masterfrom
Neumann-A:user_controls_skip_sanity_check

Conversation

@Neumann-A
Copy link
Contributor

Either give the user control over skip_sanity_check or print an error why the user is doing something stupid. This PR uses the former approach

Copy link
Member

@mensinda mensinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mensinda
Copy link
Member

mensinda commented Jun 5, 2020

Please rebase this PR on master to rerun the CI. This should get rid of the CI failures.

@vlj
Copy link

vlj commented Jun 18, 2020

What is the status of this PR ? (there is a long chain of PR dependencies for vcpkg...)

@c72578
Copy link
Contributor

c72578 commented Jun 20, 2020

@jpakkane Please have a look at this PR and merge if OK from your side.

@jpakkane
Copy link
Member

jpakkane commented Jul 3, 2020

Could you please explain a bit more what is happening here? What is the actual problem is. "Give control of option skip_sanity_check" is not very informative by itself.

@jpakkane jpakkane added this to the 0.55.0 milestone Jul 3, 2020
@Neumann-A
Copy link
Contributor Author

Neumann-A commented Jul 3, 2020

@jpakkane: there are cases where the option is simply ignored by meson.

The previous code:

        if for_machine != MachineChoice.HOST:	
            return False	
        if not self.environment.is_cross_build():	
            return False

is returning an early false without even checking if the user provided the skip_sanity_check option.
As such if the user provided skip_sanity_check=true meson still runs the sanity check if one of the early returns fires. (Which is the case for arm crosscompiles on windows.)

@jpakkane jpakkane merged commit 92075f5 into mesonbuild:master Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants